Newbie dataport problem

First of all, the recommended process is to import the raw data into a temp table, then do whatever formatting you need and then move it to a journal to review before posting. This prevents you from sticking non-validated data into a table directly. Another perk to this method is that you now have a record of the actual data which came from the data file. A month or so from now if you found a discrepency in the job table you could go back to your temp table and see if it came directly from the file and not some error in your code. You also get the first part working, verify that your data is in the temp table, then get the codeunit or report that processes and moves the data. Thus it is more incremental and easier to debug.

BTW : The INCSTR option just increments the first number it finds in the string. So if you have 73ASF55 as your number, it would increment the first digit giving you 83ASF55 instead of 73ASF56.

A better approach would be to lastChar :=COPYSTR((MAXSTRLEN(DocumentNo) -1),1);

-- This will give you the last character of the string. Then INCSTR(lastChar) that number and then do a :

newDocNo := COPYSTR(1,(MAXSTRLEN(DocNo) -1) + lastChar) to get a new document number consisting of all but the last characters of the original document no, and the last character of the original string incremented.

:-k

Ilona wrote:

"]quot;] =D> :whistle:
Hurray, This is (almost) working! Thank you David and the others!

IF JobJnlLine.FIND ('-') THEN BEGIN // Find First

But at I discovered the next 'challenges'. When really booking, it doesn't work because these fields have to be filled automaticly:

Should be Find Last (+) not Find First (-)
IF JobJnlLine.FIND ('+') THEN BEGIN // Find Last

Clue to the other bit as above
Type := Type::Resource; // Dont Validate as it resets (Clears) the "No."
VALIDATE("No."); // This fills the data you want plus cost etc:
VALIDATE(Quantity); // Calculates the total

A good practice is to do a manual journal then you know which fields to fill in, if you VALIDATE the Type you will loose the Quantity and No. field data, that is why we use the INIT OnBeforeImport that will reset the line before Import.

=D>

click on the no series and check off manual - this way both #series and manual numbers can be used.

Back to basics the only fields you need to Import are "Job No", "No." and Quantity
Optional Field #1 "Shortcut Dimension 1 Code"
This should really come across from resource when "No." is validated
Optional Field #2 "Unit of Measure"
Only needed If value is different From Resource "Base Unit of Measure"

On PreDataPort()
CLEAR(LineNo);
CLEAR(DocNo);
//Errors if not found
JobJnlBatch.GET('PROJECT','CHANTALLE');
//New Code to stop your errors
//No Number Series Needed
JobJnlBatch.TESTFIELD("No. Series",'');
JobJnlBatch.TESTFIELD("Posting No. Series",'');
//Find the Last line and get values
JobJnlLine.RESET;
JobJnlLine.SETRANGE("Journal Template Name",JobJnlBatch."Journal Template Name");
JobJnlLine.SETRANGE("Journal Batch Name",JobJnlBatch.Name);
IF JobJnlLine.FIND ('+') THEN BEGIN
LineNo := JobJnlLine."Line No.";
DocNo := JobJnlLine."Document No.";
DocDate := JobJnlLine."Document Date";
END;
//No DocNo then create one EG> 20061227_000
IF DocNo = '' THEN
DocNo := FORMAT(TODAY,0,'<Year,4><Month,2><Day,2>'+'_000');

OnBeforeImportRecord()
INIT;
// New Code
CLEAR(TempDimCode);
CLEAR(TempUOM); 
CLEAR(TempQty);

OnAfterImportRecord()
LineNo := LineNo + 10000;
DocNo := INCSTR(DocNo); 
"Document No." := DocNo;
"Journal Template Name" := JobJnlBatch."Journal Template Name";
"Journal Batch Name" := JobJnlBatch.Name;
"Line No." := LineNo;
Type := Type::Resource;

//New Code Start 3 new variables
//Move up Imported data to thge variables
TempDimCode := "Shortcut Dimension 1 Code"; // Optional
TempUOM := "Unit of Measure Code"; Optional 
TempQty := Quantity;
//New Code End

// First bring in all the other Values
VALIDATE("Job No."); 
VALIDATE("No."); 
// Validate the Optional Fields
VALIDATE("Shortcut Dimension 1 Code",TempDimCode);
VALIDATE("Unit of Measure Code",TempUOM);
// Last is the Quantity
VALIDATE(Quantity,TempQty);

Document No. must be PRJ-6-C0028 in Job Journal Line Journal Template Name='PROJECT',Journal Batch Name='CHANTALLE', Line No.=10000.

Of course I could change that number serie to something like 0001, but with so many number series....

Simple as has been said several times above Check or Delete the Number Series

If you are entering or creating a manual number either Check Manual on the "Number Series" or remove the Number Series from the "Job Journal Batch", If you use this batch for other other postings, just create a new batch for the Import with no Number Series

If your Job Journal Template and Batch both have no Number Series entered then it will accept whatever "Document No." you use!

So do one or the following options
1. Delete all the "No. Series" from both Job Journal Template (PROJECT) and the Job Journal Batch (CHANTALLE)
2. Create a brand new Template and Batch with no "No. Series", and use these in the dataport.

I checked the help on the No. Series field Manual and learned something new myself, Check markes don't work on Journals, so you need to insert no "No. Series" to use manual numbers :shock:

Manual Nos. Field
The No. Series Table

A check mark in this field indicates that the program will allow you to enter numbers manually instead of always using this number series.

For example, you can create a number series with a check mark in this field and link it to customers. Then when you create a new customer, you can assign a number manually instead of using the next number in the series.

Note
A check mark in this field has no effect for number series used in journals.

Ilona wrote:

David, then indeed it's working. But when running the batch again, the document number starts with 00070103_001. This number already exists.
It should increase the last used document number.
With running again, I mean after clearing/booking table 210 with F11 in the batchscreen, importing another text file.
Because this is something that happens every few days.
People are registering their worked hours in a Lotus Domino application daily. Weekly those hours will be exported to an txt file en then imported in Navision through this dataport.

Are you Importing more than 1 file a day?
If you are then this Document No. system will not work for you, as there is no way of saving the last number used, you will have to use the number series instead.

That would work for 1 time a day - but if you think it will happen more than once (thinking ahead) you might want to maybe add a time stamp to the doc # or change the numbering system all together.