Howdy, Stranger!
Categories
- All Categories
- 73 General
- 73 Announcements
- 66.5K Microsoft Dynamics NAV
- 18.5K NAV Three Tier
- 38.4K NAV/Navision Classic Client
- 3.6K Navision Attain
- 2.4K Navision Financials
- 115 Navision DOS
- 854 Navision e-Commerce
- 1K NAV Tips & Tricks
- 772 NAV Dutch speaking only
- 615 NAV Courses, Exams & Certification
- 2K Microsoft Dynamics-Other
- 1.5K Dynamics AX
- 264 Dynamics CRM
- 109 Dynamics GP
- 10 Dynamics SL
- 1.5K Other
- 992 SQL General
- 384 SQL Performance
- 33 SQL Tips & Tricks
- 34 Design Patterns (General & Best Practices)
- Architectural Patterns
- 10 Design Patterns
- 5 Implementation Patterns
- 53 3rd Party Products, Services & Events
- 1.7K General
- 1.1K General Chat
- 1.6K Website
- 79 Testing
- 1.2K Download section
- 23 How Tos section
- 259 Feedback
- 12 NAV TechDays 2013 Sessions
- 13 NAV TechDays 2012 Sessions
Options
Event Sub filer record to current record logic
samantha73
Member Posts: 96
Hi All
I'm subscribing to the Sales-Post codeunit and trying to create a validation based on the current document a user is interacting with. I cannot understand the reason for the below highlighted line of code to filter the document no as I assume SalesHeader already is filtered to the current record (SalesHeader.SetRange("No.", SalesHeader."No.") on user screen:
I'm subscribing to the Sales-Post codeunit and trying to create a validation based on the current document a user is interacting with. I cannot understand the reason for the below highlighted line of code to filter the document no as I assume SalesHeader already is filtered to the current record (SalesHeader.SetRange("No.", SalesHeader."No.") on user screen:
[EventSubscriber(ObjectType::Codeunit, Codeunit::"Sales-Post (Yes/No)", OnBeforeConfirmSalesPost, '', true, true)]
local procedure SetDefaultToShip(var SalesHeader: Record "Sales Header"; var DefaultOption: Integer)
var
begin
if SalesHeader.IsTemporary then
exit;
if SalesHeader."Document Type" <> SalesHeader."Document Type"::Order then
exit;
SalesHeader.Reset();
[b][b]SalesHeader.SetRange("No.", SalesHeader."No.");[/b]//Why this line[/b]
IF SalesHeader.FindFirst() THEN begin
Message('Order No %1', SalesHeader."No.");
0
Answers
You should use SETRECFILTER instead though, or at least check the "Document Type" after the FINDFIRST. No-one guarantees you document numbers to be unique to the document type, and no-one guarantees you the values in the record's fields to match the filters applied to it, until after you read that record from the database with those filters in place.
And since you mess with the filters, and you use a VAR parameter for your record, you should consider doing your checks without needing to change the filter nor fetching it fresh from the database, or do the checks on a copy which you GET from the database or FIND after COPYFILTERS and filter modifications as needed. Or else make sure the caller is ready to accept such changes (which is much easier done for an event-subscriber than for a regular subroutine.