usage of Exit after filtering in AL

samantha73

Hi
I have written a query to filter by setrange/setfilter and then findfirst to get the filtered records. If I don't use "Exit" then the query doesnt work so trying to understand why. Is using Exit best practice
example
first works and the second doesn't work

GenJournalLine2.Reset();
        GenJournalLine2.SetRange("Journal Template Name", GenJournalLine."Journal Template Name");
        GenJournalLine2.SetRange("Shortcut Dimension 2 Code", '');
        if GenJournalLine2.FindFirst() then
            if GenJournalLine2."Journal Template Name" = 'GENERAL' then
                exit else
                    error('');


        GenJournalLine2.Reset();
        GenJournalLine2.SetRange("Journal Template Name", GenJournalLine."Journal Template Name");
GenJournalLine2.SetFilter("Journal Template Name", '<>%1', 'GENERAL');
        GenJournalLine2.SetRange("Shortcut Dimension 2 Code", '');
        if GenJournalLine2.FindFirst() then
                    error('');[img]https://us.v-cdn.net/5022383/uploads/editor/ja/ab9p7k6ud0um.png[/img]

mohana_cse06

do you still need below filter in 2nd case? did you try commenting that line?
GenJournalLine2.SetRange("Journal Template Name", GenJournalLine."Journal Template Name");

samantha73

Good point . Yes I did commented it out but still not working as results do not filter by template 'General'