Why my code doesn't modify all records?

sjen

Hello,
I am writing a report and my code doesn't modify all records. It is so strange. What am I missing? I don't want to use modifyall,
When I look at my Res. Ledger Entry table I can see same resource number records but some of them have Unit of Measure Code value and some don't. They all suppose to have after I run my report.

Thank you

Resource - OnAfterGetRecord()

    ResLedgerEntry.SETRANGE("Resource No.", "No.");
    IF ResLedgerEntry.FINDSET THEN BEGIN
       ResLedgerEntry."Unit of Measure Code" := "Base Unit of Measure";
       ResLedgerEntry.MODIFY;
    END;

SanderDk

You are only modifying the first record you, need to add a repeat/until

ResLedgerEntry.SETRANGE("Resource No.", "No.");
    IF ResLedgerEntry.FINDSET(TRUE,FALSE) THEN
       REPEAT
            ResLedgerEntry."Unit of Measure Code" := "Base Unit of Measure";
            ResLedgerEntry.MODIFY;
       UNTIL ResLedgerEntry.NEXT = 0;
    END;

SanderDk

You are only modifying the first record you, need to add a repeat/until

ResLedgerEntry.SETRANGE("Resource No.", "No.");
    IF ResLedgerEntry.FINDSET(TRUE,FALSE) THEN
       REPEAT
            ResLedgerEntry."Unit of Measure Code" := "Base Unit of Measure";
            ResLedgerEntry.MODIFY;
       UNTIL ResLedgerEntry.NEXT = 0;
    END;

Duikmeester

If there is no need for triggering field logic you could use:

ResLedgerEntry.SETRANGE("Resource No.","No.");
ResLedgerEntry.MODIFYALL("Unit of Measure Code","Base Unit of Measure");

sjen

Thank you all!

RockWithNAV

@sjen Keeping performance in mind I will recommend MODIFYALLL.