Dimensions - Migrating from 2009 to 2016

doddwell

Hello

We are attempting to upgrade form 2009 to 2016 and have encountered a challenge with the move from Dimensions to Dimension Sets. I understand how Dimension Sets work and how they differ from Dimensions in 2009.

We have a custom Code Unit with the following code and it won't compile in NAV2016 because CopyDimBufToJnlLineDim does not exist in Code unit DimensionManagement [408] - as per https://msdn.microsoft.com/en-us/library/jj552487(v=nav.90).aspx

Perhaps someone could review the function below and suggest how this should look in NAV 2016.

LOCAL RunGenJnlPostLine(VAR GenJnlLine : Record "Gen. Journal Line";DimEntryNo : Integer)
TempDimBuf.DELETEALL;
TempJnlLineDim.DELETEALL;
DimBufMgt.GetDimensions(DimEntryNo,TempDimBuf);
DimMgt.CopyDimBufToJnlLineDim(
TempDimBuf,TempJnlLineDim,GenJnlLine."Journal Template Name",
GenJnlLine."Journal Batch Name",GenJnlLine."Line No.");
GenJnlPostLine.RunWithCheck(GenJnlLine,TempJnlLineDim);

Many Thanks

Kishorm

You don't need that anymore - just copy the "Dimension Set ID" field now - much simpler

To be clear, just set the "Dimension Set ID" on your GenJnlLine and then you can DELETE/REMOVE the following code...

LOCAL RunGenJnlPostLine(VAR GenJnlLine : Record "Gen. Journal Line";DimEntryNo : Integer)
TempDimBuf.DELETEALL;
TempJnlLineDim.DELETEALL;
DimBufMgt.GetDimensions(DimEntryNo,TempDimBuf);
DimMgt.CopyDimBufToJnlLineDim(
TempDimBuf,TempJnlLineDim,GenJnlLine."Journal Template Name",
GenJnlLine."Journal Batch Name",GenJnlLine."Line No.");
GenJnlPostLine.RunWithCheck(GenJnlLine,TempJnlLineDim);

Kishorm

You don't need that anymore - just copy the "Dimension Set ID" field now - much simpler

To be clear, just set the "Dimension Set ID" on your GenJnlLine and then you can DELETE/REMOVE the following code...

LOCAL RunGenJnlPostLine(VAR GenJnlLine : Record "Gen. Journal Line";DimEntryNo : Integer)
TempDimBuf.DELETEALL;
TempJnlLineDim.DELETEALL;
DimBufMgt.GetDimensions(DimEntryNo,TempDimBuf);
DimMgt.CopyDimBufToJnlLineDim(
TempDimBuf,TempJnlLineDim,GenJnlLine."Journal Template Name",
GenJnlLine."Journal Batch Name",GenJnlLine."Line No.");
GenJnlPostLine.RunWithCheck(GenJnlLine,TempJnlLineDim);

swpolo

Moreover i would like to add that
RunWithCheck(GenJnlLine)
uses only one parameter since NAV 2013, and there is no need to prepare TempJnlLineDim.

mdPartnerNL

good answer, please mark it.