[Nav 2016] Problems with xRec.Status

pjung

Hello,

i want to check if the status has been changed with this code below

[EventSubscriber] Warehouse Shipment Header.OnBeforeModify.Event(VAR Rec : Record "Warehouse Shipment Header";VAR xRec : Record "Warehouse Shipment 
IF (xRec.Status <> Rec.Status) THEN BEGIN
    ...
END;

But xRec.Status and Rec.Status has always the same value.
Other Fields of this recs are different but not the status?
Is this an issue or do I missunterstand something?

peterlinnet

Hi, I worked a bit on this and found that by doing an xRec.GET before testing Rec vs xRec it will work.
And you can even trick the system and do it in the OnAfterModify event if you have another event subscriber get the xRec OnBeforeModify and DON'T get it in your OnAfterModify event subscriber.

Try something like this:

OnRun()
Bin.GET('BLUE','A1');
Bin.Description := FORMAT(CURRENTDATETIME);
Bin.MODIFY;

LOCAL [EventSubscriber] BinOnBeforeModify(VAR Rec : Record Bin;VAR xRec : Record Bin;RunTrigger : Boolean)
xRec.GET(Rec."Location Code",Rec.Code);
MESSAGE('xRecBeforeModifyEvent: '+xRec.Description+'\'+'RecBeforeModifyEvent: '+Rec.Description);

LOCAL [EventSubscriber] BinOnAfterModify(VAR Rec : Record Bin;VAR xRec : Record Bin;RunTrigger : Boolean)
//xRec.GET(Rec."Location Code",Rec.Code);
MESSAGE('xRecAfterModifyEvent: '+xRec.Description+'\'+'RecAfterModifyEvent: '+Rec.Description);

parm

Hi,
I think that xRec only have the previous values on Pages (or forms).
The events may not have the previous values.

Regards,

parm

pjung

I don't thinkos so because other fields (for example User Id) has the previous value

postsaurav

Hi,

Give it a try -
Instead of subscribing OnBeforeModify.Event, try subscribing OnAfterModify.Event.

Before Modify Both values will be same right?

pjung

Before Modify Both values will be same right?

Yes

Instead of subscribing OnBeforeModify.Event, try subscribing OnAfterModify.Event.

After Modify are the vaules the same, too

postsaurav

Which NAV 2016 CU are you using?

pjung

Cumulative update 3 for Microsoft Dynamics NAV 2016

pjung

No one has an idea?

Peter+is1

Hi,

a- The Warehouse Shipment Header.OnModify() itself does not modify the Status so OnBeforeModify and OnAfterModify are the same for this field.

b- Could it be the Status changes are never followed by a Modify(TRUE); statement? (Use the Runtrigger)

Good luck.

pjung

a- OnBeforeModify and OnAfterModify have different states, so i think it will be modified.

b- The run trigger doesn't matter my code. Because i want only to check the state and i do not check the run trigger.
So it my code will always run if the event will be triggered.

Peter+is1

Hi,

Let me try to explain in different words.

In the Warehouse Shipment Header.OnModify() trigger in the table the Status Field is not changed.
Because there is no code in OnModify that changes the Status Field:

Code in Table 7320:
OnInsert()...

OnModify()

OnDelete()...


Can you find anywhere in NAV where the Status Field is changed followed by an Rec.Modify() statement?
If not, then you cannot test for a Status Field change in the OnBeforeModify or OnAfterModify events.

I hope this explains it better.

rajavenkat74@gmail.com

http://dynamicsuser.net/nav/b/vjeko/posts/onafter-table-event-subscriber-patterns-and-antipatterns

peterlinnet

Hi, I worked a bit on this and found that by doing an xRec.GET before testing Rec vs xRec it will work.
And you can even trick the system and do it in the OnAfterModify event if you have another event subscriber get the xRec OnBeforeModify and DON'T get it in your OnAfterModify event subscriber.

Try something like this:

OnRun()
Bin.GET('BLUE','A1');
Bin.Description := FORMAT(CURRENTDATETIME);
Bin.MODIFY;

LOCAL [EventSubscriber] BinOnBeforeModify(VAR Rec : Record Bin;VAR xRec : Record Bin;RunTrigger : Boolean)
xRec.GET(Rec."Location Code",Rec.Code);
MESSAGE('xRecBeforeModifyEvent: '+xRec.Description+'\'+'RecBeforeModifyEvent: '+Rec.Description);

LOCAL [EventSubscriber] BinOnAfterModify(VAR Rec : Record Bin;VAR xRec : Record Bin;RunTrigger : Boolean)
//xRec.GET(Rec."Location Code",Rec.Code);
MESSAGE('xRecAfterModifyEvent: '+xRec.Description+'\'+'RecAfterModifyEvent: '+Rec.Description);