About MODIFY/COMMIT

poppins

Hi everyone,

I have the following code:
IF ValueEntry.FINDSET THEN BEGIN
REPEAT
....
....
ValueEntry.MODIFY;
UNTIL (ValueEntry.NEXT=0);
END;
If something goes wrong in the execution, does it rollback? I mean, do I loose the update on entries that were modified before the error?
Do I need to add a COMMIT to make sure it is saved for good?
Thanks in advance

mohana_cse06

yes, if there is any error after this code then these changed will be rolled back.
But make sure that do you really need to save these changes even though there is error.
if yes, then use commit.

if there are any modifications to any tables before commit then they will also be saved.

vaprog

Use COMMIT sparingly and wisely. It kills performance if used to often. And more important: You'll create a mess if you place a commit statement in a function that maybe later will be called from within a transaction that should not get committed halfway through. There are no nested transactions in NAV, so you have very limited control.

mohana_cse06

yes, if there is any error after this code then these changed will be rolled back.
But make sure that do you really need to save these changes even though there is error.
if yes, then use commit.

if there are any modifications to any tables before commit then they will also be saved.

vaprog

Use COMMIT sparingly and wisely. It kills performance if used to often. And more important: You'll create a mess if you place a commit statement in a function that maybe later will be called from within a transaction that should not get committed halfway through. There are no nested transactions in NAV, so you have very limited control.