IsValidBin in Item Tracking Management Codeunit

johanna

Dear all,

I am using NAV 4 SP3 build 23305. In Warehouse Shipment Line, I run Item Tracking Lines. When I click AssistEdit in Lot No. column, the performance is very slow if my item has so many Lot. Finally, I know the cause of this slow performance using Client Monitor. The cause is in IsValidBin function, specially when system call function GetRecordID. GetRecordID is called by every Lot of my item.
I try to remove the code like below in function AssistEditLotSerialNo in Item Tracking Management codeunit.

IF ReservEntry.FIND('-') THEN REPEAT
  //{<<<<<<<<<<<<<<<<<<<<<<<<<<<< TUNING - START >>>>>>>>>>>>>>>>>>>>>>>>>>>}
  {remove:
  IF IsValidBinCode(ReservEntry,TrackingSpecification."Bin Code") OR
     NOT UseWarehouseEntries
  THEN BEGIN
  }
  //{<<<<<<<<<<<<<<<<<<<<<<<<<<<< TUNING - FINISH >>>>>>>>>>>>>>>>>>>>>>>>>>}
    TempReservEntry := ReservEntry;
    TempReservEntry.INSERT;
  //{<<<<<<<<<<<<<<<<<<<<<<<<<<<< TUNING - START >>>>>>>>>>>>>>>>>>>>>>>>>>>}
  {remove:
  END;
  }
  //{<<<<<<<<<<<<<<<<<<<<<<<<<<<< TUNING - FINISH >>>>>>>>>>>>>>>>>>>>>>>>>>}
UNTIL ReservEntry.NEXT = 0;

Is it okay to do that? I am afraid I will cause another problems.. Please help..
Thank you..

astalavista666

same problem