LS Retail POS terminal question

Eugene
Member Posts: 309
i have a very specific question about EPOS Main form (navision form object) of LS Retail
EPOS Main form is the main form representing POS terminal interface.
What puzzles me is how much code is put on the form. And what is even more troubling is the number of COMMIT statements there.
One particular that causes problems for me is in the function
WriteMgrStatus()
this commit splits a transaction that i need to be executed as single transaction and not as two separate transactions.
Even if the commit is necessary why is it not above the END ?
EPOS Main form is the main form representing POS terminal interface.
What puzzles me is how much code is put on the form. And what is even more troubling is the number of COMMIT statements there.
One particular that causes problems for me is in the function
WriteMgrStatus()
//WriteMgrStatus IF MgrKey AND (Rec."Manager Key" = "Manager Key"::Off) THEN BEGIN Rec."Manager Key" := "Manager Key"::On; //LS4.1-56 IF Rec."Manager ID" <> '' THEN IF ManagerRec.ID <> '' THEN Rec."Manager ID" := ManagerRec.ID; MODIFY; END; COMMIT;
this commit splits a transaction that i need to be executed as single transaction and not as two separate transactions.
Even if the commit is necessary why is it not above the END ?
0
Answers
-
Asking specific question like this on what the developer was thinking that wrote that code, will only get assumptions.
Yes the code on the form is ugly.
I would comment it out and see if you get any runmodal or if the field gets populated and test it out.0 -
oops, i haven't thought about possible runmodal issues, thanks for the tip0
Categories
- All Categories
- 73 General
- 73 Announcements
- 66.6K Microsoft Dynamics NAV
- 18.7K NAV Three Tier
- 38.4K NAV/Navision Classic Client
- 3.6K Navision Attain
- 2.4K Navision Financials
- 116 Navision DOS
- 851 Navision e-Commerce
- 1K NAV Tips & Tricks
- 772 NAV Dutch speaking only
- 617 NAV Courses, Exams & Certification
- 2K Microsoft Dynamics-Other
- 1.5K Dynamics AX
- 320 Dynamics CRM
- 111 Dynamics GP
- 10 Dynamics SL
- 1.5K Other
- 990 SQL General
- 383 SQL Performance
- 34 SQL Tips & Tricks
- 35 Design Patterns (General & Best Practices)
- 1 Architectural Patterns
- 10 Design Patterns
- 5 Implementation Patterns
- 53 3rd Party Products, Services & Events
- 1.6K General
- 1.1K General Chat
- 1.6K Website
- 83 Testing
- 1.2K Download section
- 23 How Tos section
- 252 Feedback
- 12 NAV TechDays 2013 Sessions
- 13 NAV TechDays 2012 Sessions