SMTP Mail Codeunit Bug CU 400

ara3n

Hello Found another bug in SMTP Codeunit

In fuction CheckValidEmailAddress

Old Code

IF NOT (
      ((EmailAddress[i] >='a') AND (EmailAddress[i] <='z')) OR
      ((EmailAddress[i] >='A') AND (EmailAddress[i] <='A')) OR     
      ((EmailAddress[i] >='0') AND (EmailAddress[i] <='9')) OR
      (EmailAddress[i] IN ['@','.','-','_']))
    THEN
      ERROR(Text001,EmailAddress);

To new code

    IF NOT (
      ((EmailAddress[i] >='a') AND (EmailAddress[i] <='z')) OR
      ((EmailAddress[i] >='A') AND (EmailAddress[i] <='Z')) OR  //Changed A to Z
      ((EmailAddress[i] >='0') AND (EmailAddress[i] <='9')) OR
      (EmailAddress[i] IN ['@','.','-','_']))
    THEN
      ERROR(Text001,EmailAddress);

The Second 'A' should be 'Z'.

The symptom is if you send an email that has capital letters it will always error out.

David_Singleton

Good find =D> at this rate, you should be working for MS in QC

ara3n

looking at the code, and how they miss stuff on testing, I wouldn't say their quality of code is top notch.

David_Singleton

ara3n wrote:

looking at the code, and how they miss stuff on testing, I wouldn't say their quality of code is top notch.

Sad but true

jlandeen

I've just run into this problem in NAV5.00 database - does anyone know if this has been fixed in later 5.0 SP1 or the NAV2009 databases?

ara3n

It has been fixed in 5.0 SP1.

jlandeen

That's great news! It did seem like a little bug.