Deleting End Blank Spaces

Savatage

I have a project I want to do because it's been bugging me forever.

When we switched to Nav a long while ago we imported our data like everyone else. All of our cust names, address, city etc. have lots of blank spaces at the end so when you put them together you get
NEW YORK__________, NY instead of
NEW YORK, NY for example.

I would like to create a report to wipe out these trailing Blanks but I am having trouble. I've read about "Hard Blanks" in previous posts so I went the Char route.

OnPreDataItem()
MyChar := 255;
MyText := FORMAT(MyChar);

OnAfterGetRecord()
FOR i := 1 TO STRLEN(Vendor.City) DO
BEGIN
IF (Vendor.City <> ' ') THEN
NewCity :=DELCHR(Vendor.City,'>',MyText);
END;

Vendor.MODIFY;

Can you help me point to where I'm going wrong?

Should I be Deleting Characters or Rebuilding the String?

nunomaia

With this code you will delete all blank chars.

So New York will become NewYork.

Until there is double blank, delete that string.

WHILE STRPOS(String, ‘  ‘) <> 0 DO BEGIN
 . . .

END;

Savatage

> Trailing character in String that matches a character in Which.

am I not using this correctly?

Alex_Chow

Umm... This may seem obvious, but you forgot the:

Vendor.City := NewCity;

before the MODIFY statement.

ara3n

wouldn't be easier to use the DELCHR function?

Vendor.City := delchr(Vendor.City,'>',' ');
Vendor.MODIFY; 

kriki

And including hard blanks:

txtBlanks := '  '; // 2 blanks
txtBlanks[1] := 255;
Vendor.City := DELCHR(Vendor.City,'>',txtBlanks);
Vendor.MODIFY;

Waldo

What do you mean with "hard" blanks? :-k
"googling" didn't give me any result

kriki

Waldo wrote:

What do you mean with "hard" blanks? :-k
"googling" didn't give me any result

Hard blanks SEEM to be blanks if you show the string. But if you test on ' ', you won't find them because they have ASCII-code=255.
It is a handy way to insert some 'blanks' to be seen but they don't behave like blanks.

Waldo

Ah ... never had any problems with this. I thought "hard" blanks were blanks who were excited

Anyway ...

I once had a job where I had to import purch. invoices from an AS/400. For one reason or another, all imported fields ended with blanks at the end (filling the field). I used ara3n's code for this, and everything worked just fine ... so I guess no hard blanks there... .

Savatage

I knew that array was killing me..thanks

This is the greatest code in the history of Navision!!!!

(for me)

HA HA!! \:D/ \:D/ \:D/

Savatage

deadlizard wrote:

Umm... This may seem obvious, but you forgot the:

Vendor.City := NewCity;

before the MODIFY statement.

I used Newcity - cause I didn't want to change the actual city until I knew it worked.

DenSter

Waldo wrote:

I thought "hard" blanks were blanks who were excited

Stuff you run into while searching Mibuso