Best Of

Hello!
Try this one



IF SalesLine.FINDSET(TRUE) THEN
REPEAT
SalesHeader.Get(SalesLine."Document Type", SalesLine."Document No.");
LastState := SalesHeader.Status; //LastState - integer
SalesHeader.Status := SalesHeader.Status::Open ; //Don't use VALIDATE
SalesHeader.MODIFY; //Don't run MODIFY trigger

SalesLine.Validate("No.", NewItemNo); // Change item no and validate

SalesOrderList += SalesLine."Document No." + ' Line: ' + Format(SalesLine."Line No.") + '\';
SalesLine.MODIFY(TRUE);

SalesHeader.Status := LastState;
SalesHeader.MODIFY;
LineCount := LineCount + 1; // Update line count var
UNTIL SalesLine.NEXT = 0;

But best way:
1. reopen Sales Order using CU 414 "Release Sales Document" function Reopen
2. Release Sales Order after Line modification using same CU

I have encountered same issue and been bothered during past few months, however it is getting closed to be resolved.

1. Get the most recent Cumulative Update, update Codeunit 1501,1502,1509,1510,1511 and 1535. There was a major update in CU13 (26893) and some other minor updates relative with workflow. Basically the most updated CU avoid using Query but use traditional SETRANGE to find records. New code also avoid unnecessary table locks caused by DELETEALL.
The above update shall minimize Workflow Step Instance table lock issue. But then the another Table 1506 Workflow Table Relation Value table lock may happen.

2. NAV out of box Workflow Template will default setup Table 1505 (Workflow - Table Relation) content. For example, Table 36 sales header has Table Relation with table 454, 37, 8000. I have deleted the table relation with Table 37 and 8000 since those relation are not really used in my workflows but just result a lot of records in table 1506 for each approval request. Reduce the number of unnecessary records help a little bit.

However, workflow relative table lock or deadlock still happen occasionally. I plan to do two more modifications:
To-do 1: Modify table 1506's UpdateRelationValue function, to avoid unnecessary record MODIFY.
To-do 2: Get rid of using Query 1501 in Table 1504 SetTableRelationValues function.

Hope the above information helps.

denpar wrote: »

@wait My question is not complete... I want to return multiple levels (item -> item variant) in the JSON, I don't think that's possible with API page

Yes you can, that is what the API does very well and easily, you are limited to three levels though, you can return Page, SubPage and then you can also return Complex Types

Good example would be Sales Invoice Entity (Page 5475) and Sales Invoice Line Entity (Page 5476) and The Sales Invoice Line Entity has field LineObjectDetailsJSON which is complex type.

To get the sales invoices and sales invoice lines your url would be something like the following

{{http}}://{{url}}/{{service}}//API/beta/companies({{companyId}})/salesInvoices?$expand=salesInvoiceLines

Here's tutorial I did a while back on complex type, https://forum.mibuso.com/discussion/72539/nav-2018-api-complex-types#latest

@MarharytaMykytenko I never tried but what you can do is OnQueryClose trigger write -

If GETLASTERRORTEXT <> '' THEN
ERROR('');

Hi

Thanks for your answers.

You have both right. I also have to change the configuration file property
<NetFx40_LegacySecurityPolicy enabled="false" />

Now it is working perfect.

Hello,

Instead of

RecordLink.Note.CreateOutStream(outStr, TextEncoding::UTF8);
outStr.WRITETEXT('AAA BBB CCC DDD EEE FFF');

you should use

TypeHelper.WriteRecordLinkNote(RecordLink,'AAA BBB CCC DDD EEE FFF');

TypeHelper is Codeunit 10 "Type Helper".
You can see an example of use in Codeunit 454.