When we post than only first row post rests are not

Comments

• Marije_Brummel Member, Moderators Design Patterns Posts: 4,262

  2006-08-28

  First of al it is strange that you delete the filters on the line table
  

  //PostedStHeader.TRANSFERFIELDS(StudentHeader); 
  //PostedStHeader."Student No.":=StudentHeader."Student No.";
  

  
  You'll need some filter on the lines.
  
  The loop on the lines is a bit strange, first you do a find on the line, but do a loop on the posted line.
  

  PostedStLine.INSERT;
  UNTIL PostedStLine.NEXT=0; 
  END; 
  
  

  
  It should be something like
  

  IF StudentLine.FIND('-') THEN 
  Repeat
  PostedStLine.INIT; 
  //StudentHeader.SETRANGE(StudentHeader."Student No.",StudentLine."Student Code"); 
  //PostedStLine.SETRANGE(PostedStLine."No.",Rec."Student No."); 
  
  PostedStLine."No.":=PostedStHeader."Document No."; 
  PostedStLine.TRANSFERFIELDS(StudentLine); 
  PostedStLine."Student Category":=StudentLine."Student Category"; 
  PostedStLine."Student Class":=StudentLine."Student Class"; 
  PostedStLine."Student Fees":=StudentLine."Student Fees"; 
  PostedStLine."Student Library Fees":=StudentLine."Student Library Fees"; 
  PostedStLine.insert;
  UNTIL StudentLine.NEXT=0; 
  

  
  I am sure that if this is corrected it still need finetuning.
  
  I would also recomend making a posting codeunit instead of coding on a form.

  Marije Brummel | Freelance Business Central Specialist

  0
• lubost Member Posts: 632

  2006-08-28

  Your code snippet isn't clear so there exist two ways:
  1. If PostedStHeader and Student Header are the same table, you need only add field Posted (Boolean) to Student Line and set its value to true during posting process.
  
  2. If PostedStHeader and Student Header are different tables your code shoud be following:
  <Control1000000014> - OnPush()
  
  PostedStHeader.RESET;
  PostedStHeader.SETRANGE(PostedStHeader."Document No.","Student No.");
  IF PostedStHeader.FIND('-') THEN
  ERROR('%1','This order already posted')
  ELSE BEGIN
  PostedStHeader.TRANSFERFIELDS(Rec);
  PostedStHeader."Document No.":="Student No.";
  PostedStHeader.INSERT;
  StudentLine.SETRANGE(StudentLine."Student Code","Student No.");
  IF StudentLine.FIND('-') THEN
  REPEAT
  PostedStLine.INIT;
  PostedStLine.TRANSFERFIELDS(StudentLine);
  PostedStLine."No.":=PostedStHeader."Document No.";
  PostedStLine.INSERT;
  UNTIL StudentLine.NEXT=0;
  StudentLine.DELETEALL; //Best practice: do this line via OnDelete trigger of Rec
  Rec.DELETE;
  END;

  0