Changing Field Values - Field in Primary Key

OnRun()
tblTableName := ' ';
tblFieldName := ' ';
tblRcdCount :=0;
Window.OPEN(Text001,tblTableName,tblFieldName,tblRcdCount);
rTableList.RESET;  // MUST BE RESET AND NOT INIT
  // INIT initialises ONLY the non-key fields
  // RESET removes all filters on the record and resets the CURRENTKEY to the primary key
  // CLEAR clears ALL fields and does also do a RESET
IF rTableList.FIND('-') THEN 
  REPEAT
// no need of extra variable    tblTableName := rTableList.TableName;
// no need of extra variable    tblFieldName := rTableList.FieldName;
    tblRenameKey := FALSE;
    CLEAR(tblRcdCount);
    Window.UPDATE;
    CLEAR(rFieldList); // CLEAR because if you don't find a record, it retains the last record found
    rFieldList.RESET;  // not really necessary because of "CLEAR(rFieldList);"
    rFieldList.SETRANGE(TableName,rTableList.TableName);
    rFieldList.SETRANGE(FieldName,rTableList.FieldName);
    IF rFieldList.FIND('-') THEN;
    
// no need of extra variable    tblTableID := rFieldList.TableNo;
// no need of extra variable    tblFieldID := rFieldList."No.";
    tblTableRef.OPEN(rFieldList.TableNo,FALSE);
    tblKeyFields := tblTableRef.CURRENTKEY;
    IF STRPOS(tblKeyFields,rTableList.FieldName) > 0 THEN BEGIN
      tblRenameKey := TRUE;
    END;
    
    IF tblTableRef.FIND('-') THEN 
      REPEAT
        tblRcdCount := tblRcdCount + 1;
        IF (tblRcdCount/500) = ROUND(tblRcdCount/500,1) THEN
          Window.UPDATE;
        tblFieldRef := tblTableRef.FIELD(rFieldList."No.");
        OldID := tblFieldRef.VALUE;
        rIDList.RESET;  //RESET and not INIT
        rIDList.SETCURRENTKEY("OLD User ID");
        rIDList.SETRANGE("OLD User ID",OldID);
        IF rIDList.FIND('-') THEN 
          REPEAT
 // no need of extra variable           NewID := rIDList."New User ID";
            IF OldID <> rIDList."New User ID" THEN
// OLD CODE              IF tblRenameKey = FALSE THEN BEGIN
              IF NOT tblRenameKey THEN BEGIN // this is more readable, because you already have a boolean, so why confronting it with a boolean?
                tblFieldRef.VALUE := rIDList."New User ID";
                tblTableRef.MODIFY(FALSE);
// a commit every record generates a lot of overhead and slows down the process                COMMIT;
              END 
              ELSE BEGIN
{NOW HERE YOU HAVE A BIG PROBLEM:this code can go into an endless loop or can skip records, because
  you change the fields of the key you are using, the NEXT-statement uses the current values in the
  record to find the next record, so you have to make a copy of the record and change THE COPY of
  the record and continue searching with the old record (even if it doesn't exist anymore)
                tblFieldRef.VALUE := rIDList."New User ID";
                tblTableRef.INSERT(FALSE);
                tblFieldRef.VALUE := OldID;
                tblTableRef.DELETE(FALSE);
}
                tblTableRef2 := tblTableRef.DUPLICATE;
                tblFieldRef2 := tblTableRef2.FIELD(rFieldList."No.");
                tblTableRef2.DELETE(FALSE);
                tblFieldRef2.VALUE := rIDList."New User ID";
                tblTableRef2.INSERT(FALSE);
// a commit every record generates a lot of overhead and slows down the process               COMMIT;
              END;
            IF (tblRcdCount/500) = ROUND(tblRcdCount/500,1) THEN // new:a commit every 500 records
              COMMIT

          UNTIL rIDList.NEXT = 0;
      UNTIL tblTableRef.NEXT = 0;
  UNTIL rTableList.NEXT = 0;
Window.CLOSE;

Timo Lässer wrote:

kriki wrote:

IF (tblRcdCount/500) = ROUND(tblRcdCount/500,1) THEN // new:a commit every 500 records 
  COMMIT

You can also write

IF tblRcdCount MOD 500 = 0 THEN // new:a commit every 500 records 
  COMMIT;

timProgress := TIME;

IF timProgress < TIME - 3000 THEN BEGIN // every 3 seconds
  timProgress := TIME;
  COMMIT;
END;

SHardy wrote:

However, regarding the tblTableName & tblFieldName variables...

are these not still required for my WINDOW?

UPDATE(1,"the value you want to show");