Categories
- 70.4K All Categories
- 73 General
- 73 Announcements
- 64.7K Microsoft Dynamics NAV
- 17.1K NAV Three Tier
- 38.2K NAV/Navision Classic Client
- 3.6K Navision Attain
- 2.4K Navision Financials
- 112 Navision DOS
- 850 Navision e-Commerce
- 904 NAV Tips & Tricks
- 769 NAV Dutch speaking only
- 610 NAV Courses, Exams & Certification
- 1.9K Microsoft Dynamics-Other
- 1.5K Dynamics AX
- 222 Dynamics CRM
- 107 Dynamics GP
- 9 Dynamics SL
- 1.5K Other
- 975 SQL General
- 379 SQL Performance
- 31 SQL Tips & Tricks
- 23 Design Patterns (General & Best Practices)
- Architectural Patterns
- 6 Design Patterns
- 3 Implementation Patterns
- 53 3rd Party Products, Services & Events
- 1.6K General
- 1K General Chat
- 1.6K Website
- 79 Testing
- 1.2K Download section
- 23 How Tos section
- 253 Feedback
- 12 NAV TechDays 2013 Sessions
- 13 NAV TechDays 2012 Sessions
Mass updating sales lines
markcle
Member Posts: 59
Hi All
Written a few small extensions and need to write one that updates all sales lines with no shipments. We frequently have to swap out items for replacements (but need to keep the old ones as we may sell later)
So I need to create a codeunit to swap the item on sales lines. I've got it working except for when the sales order is released.
How do I check if it's open, reopen and re-release after update?
Here's where I got to with the code unit
Written a few small extensions and need to write one that updates all sales lines with no shipments. We frequently have to swap out items for replacements (but need to keep the old ones as we may sell later)
So I need to create a codeunit to swap the item on sales lines. I've got it working except for when the sales order is released.
How do I check if it's open, reopen and re-release after update?
Here's where I got to with the code unit
var
// Local var
SalesLine: record "Sales Line";
SalesHeader: record "Sales Header";
ReleasesSalesLine: record "Sales Line";
LineCount: Integer;
SalesOrderList: Text;
begin
LineCount := 0;
// Find all sales lines with the item on
SalesLine.SETRANGE("Document Type", 1);
SalesLine.SETRANGE(Type, SalesLine.Type::Item);
SalesLine.SetFilter("No.", '= %1', SourceItemNo);
IF SalesLine.FINDSET(TRUE) THEN
REPEAT
SalesHeader.Get(SalesLine."Document Type", SalesLine."Document No.");
SalesLine.Validate("No.", NewItemNo); // Change item no and validate
SalesOrderList += SalesLine."Document No." + ' Line: ' + Format(SalesLine."Line No.") + '\';
SalesLine.MODIFY(TRUE);
LineCount := LineCount + 1; // Update line count var
UNTIL SalesLine.NEXT = 0;
Message('Done ' + '\' + SalesOrderList);
end;
0
Answers
Try this one
IF SalesLine.FINDSET(TRUE) THEN
REPEAT
SalesHeader.Get(SalesLine."Document Type", SalesLine."Document No.");
LastState := SalesHeader.Status; //LastState - integer
SalesHeader.Status := SalesHeader.Status::Open ; //Don't use VALIDATE
SalesHeader.MODIFY; //Don't run MODIFY trigger
SalesLine.Validate("No.", NewItemNo); // Change item no and validate
SalesOrderList += SalesLine."Document No." + ' Line: ' + Format(SalesLine."Line No.") + '\';
SalesLine.MODIFY(TRUE);
SalesHeader.Status := LastState;
SalesHeader.MODIFY;
LineCount := LineCount + 1; // Update line count var
UNTIL SalesLine.NEXT = 0;
But best way:
1. reopen Sales Order using CU 414 "Release Sales Document" function Reopen
2. Release Sales Order after Line modification using same CU
An implicit conversion is being performed from a value of type 'Enum "Sales Document Status"' to a value of type 'Integer'. This conversion can lead to unexpected runtime issues. This warning will become an error in a future release.
Fixed by using this:
LastState: Enum "Sales Comment Document Type";