NAV 2017 - Customize Code Problem in Report

AlexLim · 2017-01-16

Dear Nav Expert,

I have tried to find any related post about my question, however i have no luck as I not even know what keyword I should use, sorry if got similar post.

Back to question, recently I tried to add additional column in report, named as "No." and it show report line no.(example 1, 2 3... etc). You may check the sample I attached.

I use my own customize code to handle in VB(I simply don't like to pass many value from Nav to VB

). However some odd thing happen. When I print or preview with multiple document, result show exactly same and "No." work as i expected. But when i print in PDF or direct printer in single document, its show 4,5,6 instead of 1,2,3, more weird is preview, word and excel work correctly.

Not sure how to upload my work so i write the code here.

{ //This code is writen in VB Code
Shared LineNo as Integer
Shared ExDocNo as String

Public Function GetLineNo (CurDocNo as String)
If ExDocNo <> CurDocNo then
LineNo = 1
ExDocNo = CurDocNo
else
LineNo = LineNo + 1
End if

Return LineNo
End Function
}

{//And This code is added in new column, before Item No.
=Code.GetLineNo(Fields!No_SalesInvHdr.Value)
}

Is anyone have idea what happen? Is my code not correct or something?

Thank you.

Best Regards,
Alex

gerdhuebner · 2017-01-17

May be you should set LineNo to zero at a more appropriate place in the report (for example within the SetData tablix), because it looks like, that the LineNo textbox is rendered more than once in the case of PDF output. Furthermore, LineNo should also be set to zero, when a new copy of a document starts.
As has already been proposed, it is more easy to set LineNo from within C/AL-code and pass it as a field to the report layout. Of course, LineNo := 0; should not be in the OnInitReport trigger, but in the CopyLoop-OnAfterGetRecord trigger and the increment instruction LineNo += 1; should be in the Sales Invoice Line - OnAfterGetRecord trigger confined to the case, where Type and No. are both not zero or empty, respectively.

Dolsha · 2017-01-17

I advise all the calculations to carry out in DEV.

Global variable: LineNo integer
OnInitReport():
LineNo := 0;
SalesInvHdr - OnAfterGetRecord():
LineNo +=1;

Then LineNo determine for Layout.
GL

gerdhuebner · 2017-01-17

May be you should set LineNo to zero at a more appropriate place in the report (for example within the SetData tablix), because it looks like, that the LineNo textbox is rendered more than once in the case of PDF output. Furthermore, LineNo should also be set to zero, when a new copy of a document starts.
As has already been proposed, it is more easy to set LineNo from within C/AL-code and pass it as a field to the report layout. Of course, LineNo := 0; should not be in the OnInitReport trigger, but in the CopyLoop-OnAfterGetRecord trigger and the increment instruction LineNo += 1; should be in the Sales Invoice Line - OnAfterGetRecord trigger confined to the case, where Type and No. are both not zero or empty, respectively.

AlexLim · 2017-01-20

Hi Dolsha & gerdhuebner,

Thank for reply and sorry I late reply.

The solution provided actually I used to use, but I have this idea is start from when I customize a report that required different type of sorting that cannot find in table key, and i not allow to add new key for sorting or simply add new key is too much since only use in 1 report.

And that the problem come in, if the report have no. Then the output become not in sequence i wanted.

As I know the sorting only can done in 2 way, key or VB. Of course this question have solution since very beginning, but just wanted know is any other option.

Edit :
gerdhuebner, your solution is worked, I add some simple reset code in setdata table, and its reset to no i wanted. Thank you very much.

But just not understand, why its only happen in single document print out?

NAV 2017 - Customize Code Problem in Report

Best Answer

Answers

Categories