wont set one field!

nverma · 2012-07-10

Could someone look at the following code and tell me what I am doing wrong. The line that has a bunch of stars with them, it wont execute it. It pulls the correct FA Class code and it sets the correct no. of depreciation year in the depreciation book form, but it wont set the correct depreciation method field. Any idea why???

This code is written in OnValidate trigger (FA class code)

FA.GET("No.");
FADeprBook.SETRANGE("FA No.", FA."No.");
FASetup.GET;
//FAClass.GET;

IF FADeprBook.FINDSET THEN 
  IF FASetup."Default Depr. Book" <> '' THEN
  BEGIN
    FADeprBook.SETRANGE("Depreciation Book Code", FASetup."Default Depr. Book");
    IF FADeprBook.FINDFIRST = TRUE THEN

    IF xRec."FA Class Code" = '' THEN
    BEGIN
        FADeprBook."FA Posting Group" := Rec."FA Class Code";
        FAClass.SETFILTER(Code, Rec."FA Class Code");
         IF FAClass.FINDSET THEN
         REPEAT

           FADeprBook."No. of Depreciation Years" := FAClass."Default Years"; //  WORKS Perfectly
           FADeprBook."Depreciation Method" := FAClass."Default Method"; //************* DOES NOT WORK
         UNTIL FAClass.NEXT = 0;
    END
    ELSE
      IF CONFIRM ('Do you want to change the FA Posting Group on Depreciation Book %1?', TRUE, FASetup."Default Depr. Book") THEN
      BEGIN
         FADeprBook."FA Posting Group" := Rec."FA Class Code";
         FAClass.SETFILTER(Code, Rec."FA Class Code");
         IF FAClass.FINDSET THEN
         REPEAT

             FADeprBook."No. of Depreciation Years" := FAClass."Default Years";   //  WORKS Perfectly
             FADeprBook."Depreciation Method" := FAClass."Default Method"; //************* DOES NOT work. 
         UNTIL FAClass.NEXT = 0;
      END
      ELSE
        Rec."FA Class Code" := xRec."FA Class Code";
  END;

FADeprBook.MODIFY;

FAClass.Depreciation method is an option field and FADerpBook."Depreciation Method" is also an option field.

nverma · 2012-07-10

Nevermind, I found the solution to the problem. What had happened was, I added an additional option to the Depreciation method in the fa depreciation book table, but i didnt add it to the default method in the FA Class table

That is why it was messing it up.

Savatage · 2012-07-10

I'll take a guess that FADeprBook."Depreciation Method" is an option type,
and you have an option issue.

edit::When adjusting option fields like adding values, you have to find where else in the system they are used else you can cause yourself an error due to a mismatch.

nverma · 2012-07-10

This is sorta off topic,but I have a generic question:

I know that GET statement fetches the primary keys of the table. Lets say the Primary Key of the Table (lets call the table 'FA') is: FA No. & FA Depreciation Book Code

Can someone clarify the difference between these 3 statements:
1) FA.GET;
2) FA.GET (FAdeprBook."No.");
3) FA.GET (FAdeprBook."No.", FAdeprBook."Depreciation Code");

I know it a silly question, but I just want this clarification before I misunderstand the concept.

i know the concept, i just want to make sure what I know is the correct...

DenSter · 2012-07-10

nverma wrote:

i know the concept

By asking this question, you prove that you DON'T understand the concept.

You use GET to retrieve one and only one record from the database, for which you know all of the primary key values. If you don't know all of the primary key values, and you still use GET, you are using the wrong keyword.

nverma · 2012-07-10

What happens if I only provide the GET statement with only one of the primary key fields and also what happens if i dont provide any of the fields.

1) FA.GET (FAdeprBook."No.");
2) FA.GET;

DenSter · 2012-07-10

Just don't use it like that.

If you don't have all primary key values, you set filters and you use one of the FIND statements (FINDFIRST, FINDLAST, FINDSET) to retrieve the records.

Savatage · 2012-07-10

I'm sure I gave you these links before.

Add them to your favorites.
http://msdn.microsoft.com/en-us/library/dd301056.aspx
http://msdn.microsoft.com/en-us/library/dd355032

mohana_cse06 · 2012-07-11

Savatage wrote:

I'm sure I gave you these links before.

Add them to your favorites.
http://msdn.microsoft.com/en-us/library/dd301056.aspx
http://msdn.microsoft.com/en-us/library/dd355032

Do you think someone will read these links?
If yes, they never ask basic technical questions. :thumbsdown:

dans · 2012-07-11

nobody bothers reading manual these days

mohana_cse06 · 2012-07-11

dans wrote:

nobody bothers reading manual these days

Read my Lips :thumbsup:

Sog · 2012-07-11

mohana_cse06 wrote:

dans wrote:

nobody bothers reading manual these days

Read my Lips :thumbsup:

I'd rather read a manual than reading your lips :P.

The usual steps for calling help should be
a: is it a tech question or a business question?
b: for tech questions: is it beginner, advanced or exotic?
Beginner: F1, Advanced: Manual, Exotic: Mibuso \:D/

wont set one field!

Answers

Categories