Adjust Cost Item Entries in NAV 4.0 SP3 - Endless Loop

Hi all,

I have a client that is running into an endless loop when running Adjust Cost Item Entries on a few specific items. As is the case with these endless loop, the costing method is Average. And yes, I have read all of the relevant material here on MIBUSO and Microsoft's Hotfix in KB978605. I applied the recommended hotfix, but surprisingly, it didn't solve the problem. I also realized that the code Microsoft recommends to delete doesn't exist in the 5895 codeunit, even though the database and client are 4.3, so I did my best to apply the patch. Obviously, it's not working. I would like to get your opinion and advice on what may have went wrong in the hotfix patching. I enclosed the code that I patched below. Kindly please review the code and let me know if and where it went all wrong.

I sincerely appreciate all your efforts and help. This won't be forgotten.

AvgValueEntriesToAdjustExist:

...
  IF FIND('-') THEN BEGIN
    FindNextRange := TRUE;
    SETRANGE("Valuation Date","Valuation Date");
    REPEAT
      IF "Item Charge No." = '' THEN BEGIN
        IF "Valued By Average Cost" AND NOT Adjustment AND ("Valued Quantity" < 0) THEN BEGIN
          OutbndValueEntry := ValueEntry;
          OutbndValueEntry.INSERT;
          FindNextRange := FALSE;
        END;

// GRA1.01 - Add Start
// Add the following lines.
        IF ("Entry Type" = "Entry Type"::Revaluation) OR
        NOT (("Item Ledger Entry Type" = "Item Ledger Entry Type"::Transfer) AND
        InvtSetup.IsAvgCostCalcTypeItem)
        THEN BEGIN
          ExcludedValueEntry := ValueEntry;
          ExcludedValueEntry.INSERT;
        END;
// End of the added lines.
// GRA1.01 - Add End

// GRA1.01 - Delete Start
{
        IF "Partial Revaluation" OR "Valued By Average Cost" THEN BEGIN
          ExcludedValueEntry := ValueEntry;
          ExcludedValueEntry.INSERT;
        END;
}
// GRA1.01 - Delete End

      END;
    UNTIL NEXT = 0;
  END;

  IF FindNextRange THEN BEGIN
    AvgCostAdjmtEntryPoint."Valuation Date" := GetNextDate("Valuation Date");
    AvgValueEntriesToAdjustExist(OutbndValueEntry,ExcludedValueEntry,AvgCostAdjmtEntryPoint);
  END;
...

IsExcludeEntryFromAvgCostCalc:

...
WITH ValueEntry DO BEGIN
  IF "Partial Revaluation" THEN
    EXIT(TRUE);

  IF "Item Ledger Entry No." = OutbndValueEntry."Item Ledger Entry No." THEN
    EXIT(TRUE);

// GRA1.01 - Add Start
  IF "Item Ledger Entry Type" = "Item Ledger Entry Type"::Transfer THEN

    IF Adjustment AND ("Applies-to Entry" < OutbndValueEntry."Entry No.") THEN
      EXIT(FALSE);
// GRA1.01 - Add End

  IF NOT "Valued By Average Cost" THEN
    EXIT(FALSE);

// GRA1.01 - Delete Start
{
  IF NOT InvtSetup.IsAvgCostCalcTypeItem AND
     ("Item Ledger Entry Type" = "Item Ledger Entry Type"::Transfer) AND
     ("Valued Quantity" >= 0)
  THEN
    EXIT(FALSE);
}
// GRA1.01 - Delete End
...

UpdateAvgCostAdjmtEntryPoint:

...
// GRA1.01 - Delete Start
{
AvgCostAdjmtEntryPoint.UpdateValuationDate(
  ValueEntry,IsAvgCostItem,InvtSetup.IsAvgCostCalcTypeItem);
}
// GRA1.01 - Delete End

// GRA1.01 - Add Start
// Add the following lines.
IF (ValueEntry."Item Ledger Entry Type" = ValueEntry."Item Ledger Entry Type"::Transfer) AND
    InvtSetup.IsAvgCostCalcTypeItem
THEN
  EXIT;

AvgCostAdjmtEntryPoint.UpdateValuationDate(ValueEntry,IsAvgCostItem,InvtSetup.IsAvgCostCalcTypeItem);
// End of the added lines.
// GRA1.01 - Add End