Converting the the first character to numbers.

if this field is not an primary key, or part of them. Than you can do following.

YourTable.findset(true)
repeat
  case copystr(YourTable."YourCodeField",1,1) of
    'A':
      begin
        YourTable."YourCodeField" := '01' + copystr(YourTable."YourCodeField",2,Strlen(YourTable."YourCodeField"));
        //or 01' + DELCHR(YourTable.YourCodeField,'<',DELCHR('A');
        YourTable.modify;
      end;
    'B':
      begin
        YourTable."YourCodeField" := '02' + copystr(YourTable."YourCodeField",2,Strlen(YourTable."YourCodeField"));
        YourTable.modify;
      end;  
    'C':
      begin
      end; 
  end;
until YourTable.next = 0;

#-o another one, that savatage are faster. fuck, i should press the "turbo" button on my old 386 computer :-D

than my old DOS Navision application is to fast :-D

Hey guys, why you are doing it in this hard way? You need just one line of code...

b := FORMAT(a[1]-'A'+1,2,'<integer,2><filler character,0>')+COPYSTR(a,2);

a - is variable of type Code with the original string.
b - is variable of type Code with result

Do you know how it works? I will let you some time to think about it, if you want I can describe it for the rest, who do not understand...

That's why he has 6220 posts - he's really great at this Nav stuff \:D/

garak wrote:

#-o another one, that savatage are faster. fuck, i should press the "turbo" button on my old 386 computer :-D

HAAHHAHA.... Oh my god... This has to be the post of the month!

DenSter wrote:

garak wrote:

one line coding is for old navision coder

Not old, just REALLY good

Thanks Daniel, that you have taken my side...

I do not feel old... but it is true, that my first computer was Atari 800XE... :whistle:

asembereng wrote:

Kine i am confuse can you explain what that simple line does?

Ok, I will try.

First some basics:

Datatype Text (or Code) is defined as ARRAY of CHARs. Char is a datatype, which has size of one byte and it means that the values are 0-255. The char datatype can be used as number (0-255) or as a Character ('A', 'B', '$' etc.). Relation between character and number is, that each character has some ordinal number which is defined by ASCII table. It means, that e.g. 'A' = 65, 'B' = 66, 'Z'= 90 etc. You can use mathematical operators with both "notations" (number and character) - it means you can do e.g. 'A'-'B' = 1, if both operators are of type char. And this is the base of the expression.

Ok, let's go:

*** a[1]-'A'+1
a[1] = first char from the "String" (variable) a - it is the first character in the text saved in variable a. Because Text (Code) datatype is ARRAY of chars, you can use indexing to read some component of the array... it means that a[1] is of type Char and it is the char on position 1...

By substracting 'A' from any char (if we are using just uppercase characters from period A..Z), you will get the position of the character in the alphabet (A=0, B=1,...). And because you want to have A as 1, I am adding 1 to the result.

***FORMAT(Something,2,'<integer,2><filler character,0>')
this will format the number in "Something" into text with length 2 filled with 0 from left. It means e.g. 1 is formated as '01' etc.

***+COPYSTR(a,2)
add the rest of the text, without first character (take substring, starting on 2nd character, to the end)

As you can see, it is about understanding the datatypes and some basic things from programming languages (arrays, string representation, ,,mathematical operations over the different datatypes).

I hope that this description will help you to understand more deeply some things, and that it will not discourage you from NAV... 8)

with format(a[1] - 'A' + 1) the programm do following:

he use the first charakter of String a. This is an Letter. The Letter A has the AsCII Code 65. B has the Code 66 .....

Now whe subtract from ASCII 65 the Value of 'A' (this is 65)
So 65 - 65 + 1 is 1. With the second parameter ",2,'<integer,2><filler character,0>'" we say the lenght must be 2. with the 3 parameter wie say that if the lenght is < 2 we will out this wit 0 at begin

Thanks garak for making this simple description... may be it will be much more understandable than my one... :whistle:

Alex Chow wrote:

I understand the code. What I want some explaining on is how are you able to figure out that you can use a string variable with an array syntax.

Its much like += its one of those things that had been there all the time, (it used to be in the STX file I think) but took a while before everyone started to use it. The reason being fear that it would not work in the next version. But once NAV started using += in the base app, its seems acceptable for us to do it to.

Unfortunately with the Text as array of CHAR, we now know that support for this undocumented "feature" will not be around in future versions of NAV. So we are all going to have to go around and do some code clean up I guess.

kine wrote:

Why? This is common for all languages I know. Difference is jsut if text is array of char or wide char. But it is from basic definition of the text string... :-) I am not afraid that this will be not supported in next versions. Every language is using indexing to access elements of the string. 8)

Hmm I think you missunderstood. I didn't say you shoudln't use it. I use it my self. I just said it WILL NOT BE SUPPORTED in future versions of NAV.

Its not NDA anymore, so we are allowed to say this right?

1 personal question about this:

To avoid writting code that is specific to each letter of the alphabet you can useCode:
STRPOS('ABCDEFGHIJKLNOPQRSTUVWXYZ',COPYSTR(OriginalCode,1,1))
to convert the leading letter to an integer. You can then format the integer and go from there.

DOES THIS REALLY WORK? :shock:

doesn't nav search ABCDEFGHIJKLNOPQRSTUVWXYZ in the substring that is e.g. 'A' or 'D'? :shock: :shock:

David Singleton wrote:

kine wrote:

But still I do not understand about what you are still talking... I do not know anything which can have impact to this... :-k

Impact to what? I think we are both lost here. :?:

It seems... we can go through it elsewhere than on this forum...